Alexander Mikhaylenko [Mon, 11 May 2020 15:03:51 +0000 (20:03 +0500)]
tests: Remove redundant image from testdialog
Alexander Mikhaylenko [Mon, 11 May 2020 14:54:32 +0000 (19:54 +0500)]
tests: Connect signal properly for testvolumebutton
Alexander Mikhaylenko [Mon, 11 May 2020 14:53:31 +0000 (19:53 +0500)]
tests: Remove orientation from testvolumebutton
GtkVolumeButton isn't orientable anymore.
Alexander Mikhaylenko [Mon, 11 May 2020 14:51:18 +0000 (19:51 +0500)]
test: Stop using stock-size for teestverticalcells
Alexander Mikhaylenko [Mon, 11 May 2020 14:47:58 +0000 (19:47 +0500)]
tests: Fix testtreeelistmodel
Stop using GtkContainer API for GtkListBoxRow and GtkToggleButton.
Alexander Mikhaylenko [Mon, 11 May 2020 14:32:52 +0000 (19:32 +0500)]
tests: Fix teststackedheader
Connect to signals programmatically.
Alexander Mikhaylenko [Mon, 11 May 2020 14:27:41 +0000 (19:27 +0500)]
tests: Fix teststack "add icon" button
Alexander Mikhaylenko [Mon, 11 May 2020 14:21:03 +0000 (19:21 +0500)]
tests: Fix testselectionmode
Stop using <packing/> and GtkContainer API for random widgets.
Alexander Mikhaylenko [Mon, 11 May 2020 14:13:04 +0000 (19:13 +0500)]
tests: Fix testoverlay
Stop using child properties and margin property.
Alexander Mikhaylenko [Mon, 11 May 2020 14:08:56 +0000 (19:08 +0500)]
tests: Simplify testorientable
Since GtkButtonBox is gone, remove the separator and change grid to box.
Alexander Mikhaylenko [Mon, 11 May 2020 14:03:53 +0000 (19:03 +0500)]
tests: Remove testmodelbutton
GtkModelButton is private now, so it can't work anymore.
Alexander Mikhaylenko [Mon, 11 May 2020 13:55:15 +0000 (18:55 +0500)]
tests: Remove use-popover from testmenubutton
The corresponding property doesn't exist anymore.
Alexander Mikhaylenko [Mon, 11 May 2020 13:54:53 +0000 (18:54 +0500)]
tests: Fix testlogout
Stop using GtkApplication::quit signal.
Alexander Mikhaylenko [Mon, 11 May 2020 13:54:23 +0000 (18:54 +0500)]
tests: Fix testiconview
Stop using GtkContainer API for GtkPopover.
Alexander Mikhaylenko [Mon, 11 May 2020 13:39:32 +0000 (18:39 +0500)]
tests: Fix testheightforwidth layout
Stop using child properties and setting visible=true everywhere.
Alexander Mikhaylenko [Mon, 11 May 2020 13:31:59 +0000 (18:31 +0500)]
tests: Expand content for testheaderbar
Alexander Mikhaylenko [Mon, 11 May 2020 13:11:48 +0000 (18:11 +0500)]
tests: Fix testgtk
An assorted collection of fixes.
Alexander Mikhaylenko [Sun, 10 May 2020 23:58:36 +0000 (04:58 +0500)]
tests: Fix testgmenu
GtkMenuButton isn't a GtkButton anymore.
Alexander Mikhaylenko [Sun, 10 May 2020 23:57:01 +0000 (04:57 +0500)]
tests: Add missing margin for testglarea
Alexander Mikhaylenko [Sun, 10 May 2020 23:55:22 +0000 (04:55 +0500)]
tests: Fix testgiconpixbuf test
Don't use GtkContainer API on GtkWindow.
Alexander Mikhaylenko [Sun, 10 May 2020 23:52:04 +0000 (04:52 +0500)]
tests: Fix testfontchooser layout
Remove an extra box so that we don't need to expand the chooser.
Alexander Mikhaylenko [Sun, 10 May 2020 23:47:26 +0000 (04:47 +0500)]
tests: Fix testfilechooser test
Don't use GtkContainer API on GtkWindow.
Alexander Mikhaylenko [Sun, 10 May 2020 22:47:39 +0000 (03:47 +0500)]
tests: Add missing margin for testentrycompletion
Alexander Mikhaylenko [Sun, 10 May 2020 22:38:10 +0000 (03:38 +0500)]
tests: Fix testdnd popup
Don't use GtkContainer API for GtkWindow.
Alexander Mikhaylenko [Sun, 10 May 2020 22:36:02 +0000 (03:36 +0500)]
tests: Fix testdialogtest
Fix deprecations in UI files, add a missing expand.
Alexander Mikhaylenko [Sun, 10 May 2020 22:22:50 +0000 (03:22 +0500)]
tests: Update testcombochange test
GtkComboBox doesn't have list mode anymore, remove that.
Alexander Mikhaylenko [Sun, 10 May 2020 22:22:34 +0000 (03:22 +0500)]
tests: Fix testcombo
Don't use GtkContainer API on GtkFrame.
Alexander Mikhaylenko [Sun, 10 May 2020 22:22:15 +0000 (03:22 +0500)]
tests: Fix testcalendar layout
Add a missing expand.
Alexander Mikhaylenko [Sun, 10 May 2020 21:49:09 +0000 (02:49 +0500)]
tests: Add missing margin to simple test
Alexander Mikhaylenko [Sun, 10 May 2020 21:46:50 +0000 (02:46 +0500)]
tests: Fix testadjustsize test
Don't assume GtkWindow is a container, also add missing expand and margin.
Alexander Mikhaylenko [Sun, 10 May 2020 21:46:28 +0000 (02:46 +0500)]
tests: Fix testappchooser test
Don't assume GtkWindow is a container.
Alexander Mikhaylenko [Sun, 10 May 2020 21:32:41 +0000 (02:32 +0500)]
tests: Fix testaccel layout
hexpand doesn't matter there, set vexpand instead.
Alexander Mikhaylenko [Sun, 10 May 2020 21:32:27 +0000 (02:32 +0500)]
tests: Fix testaccel indentation
Alexander Mikhaylenko [Sun, 10 May 2020 21:26:42 +0000 (02:26 +0500)]
tests: Fix syncscroll
Set expand for the scrolled windows.
Alexander Mikhaylenko [Sun, 10 May 2020 21:18:06 +0000 (02:18 +0500)]
tests: Fix overlayscroll
Set expand for the scrolled window.
Alexander Mikhaylenko [Sun, 10 May 2020 20:59:25 +0000 (01:59 +0500)]
tests: Fix print-editor
Don't assume GtkWindow is a container.
Aurimas Černius [Sun, 10 May 2020 19:34:16 +0000 (22:34 +0300)]
Updated Lithuanian translation
Matthias Clasen [Sun, 10 May 2020 18:15:57 +0000 (18:15 +0000)]
Merge branch 'wip/exalm/headerbar-dragging' into 'master'
Extract GtkWindow dragging and titlebar actions
Closes #2689
See merge request GNOME/gtk!1814
Yuri Chornoivan [Sun, 10 May 2020 16:03:34 +0000 (16:03 +0000)]
Update Ukrainian translation
Piotr Drąg [Sun, 10 May 2020 12:34:33 +0000 (14:34 +0200)]
Update POTFILES.in
Christoph Reiter [Sun, 10 May 2020 06:31:37 +0000 (08:31 +0200)]
CI: install brotli in msys2
Not a direct dependency, but the freetype package is missing it atm
Matthias Clasen [Sun, 10 May 2020 00:36:49 +0000 (00:36 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
window: Remove some dead code
Closes #2726 and #2724
See merge request GNOME/gtk!1862
Matthias Clasen [Sat, 9 May 2020 23:41:30 +0000 (19:41 -0400)]
placesview: Don't do the same thing twice
When the schema is supported, we want to remove
the error style class, not add it again. Pointed
out by Rafał Mikrut.
Fixes: #2724
Matthias Clasen [Sat, 9 May 2020 23:40:06 +0000 (19:40 -0400)]
gsk: Fix a typo
We were checking x_offset twice, when we meant to check
x_offset and y_offset. Pointed out by Rafał Mikrut.
Fixes: #2726
Matthias Clasen [Sat, 9 May 2020 23:23:29 +0000 (19:23 -0400)]
Add a test for refcounts under reordering
It turns out that we have a ref leak at the very
core of our dom model :( gtk_widget_insert_before/after
leak a reference if the widget was already under
the same parent. This is something that GtkBox
frequently does. It shows up e.g. when packing
widgets at the end in a headerbar.
Matthias Clasen [Sat, 9 May 2020 23:27:05 +0000 (19:27 -0400)]
widget: Don't leak a reference when reordering
When reordering a widget that is alrady under the
same parent, we must not take another reference.
Matthias Clasen [Sat, 9 May 2020 13:22:14 +0000 (09:22 -0400)]
window: Remove some dead code
We are not attaching windows anymore.
Daniel Șerbănescu [Sat, 9 May 2020 18:19:28 +0000 (18:19 +0000)]
Update Romanian translation
Florentina Mușat [Sat, 9 May 2020 17:18:59 +0000 (17:18 +0000)]
Update Romanian translation
Kristjan SCHMIDT [Sat, 9 May 2020 10:20:43 +0000 (10:20 +0000)]
Update Esperanto translation
Matthias Clasen [Fri, 8 May 2020 15:50:33 +0000 (15:50 +0000)]
Merge branch 'carlosgc/content-provider-union-write' into 'master'
clipboard: GdkContentProviderUnion should return after writing the first matched format
See merge request GNOME/gtk!1856
Matthias Clasen [Fri, 8 May 2020 15:05:50 +0000 (15:05 +0000)]
Merge branch 'tintou/gsk-transform-autocleanup' into 'master'
gsk: Add GskTransform autocleanup definition
See merge request GNOME/gtk!1859
Matthias Clasen [Fri, 8 May 2020 14:55:46 +0000 (14:55 +0000)]
Merge branch 'gbsneto/css-dequeue-fix' into 'master'
csswidgetnode: Don't check for container
See merge request GNOME/gtk!1861
Matthias Clasen [Fri, 8 May 2020 14:51:59 +0000 (14:51 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!1860
Georges Basile Stavracas Neto [Fri, 8 May 2020 13:51:54 +0000 (10:51 -0300)]
csswidgetnode: Don't check for container
The conditions to queue and dequeue a CSS validation
are different; while queueing checks if the widget is
a root, dequeueing checks that AND if the widget is
a container.
GtkWindow is not a GtkContainer anymore, and that is
causing validations to be queued, but never dequeued.
Don't require the widget to be a GtkContainer for
dequeuing.
Matthias Clasen [Fri, 8 May 2020 13:07:29 +0000 (09:07 -0400)]
placeview: Hide the protocols grid when its empty
Seeing just the bold headings at the bottom of the
popover is confusing, so just hide the entire grid
in this case.
Matthias Clasen [Fri, 8 May 2020 12:47:06 +0000 (08:47 -0400)]
droptarget: Fix confusion around ::leave signal
The leave signal should not take any arguments,
don't pass the GdkDrop. Update the documentation,
fix the emission and update users to match.
This was showing up as crash when dragging files
over the places sidebar.
Corentin Noël [Fri, 8 May 2020 07:14:55 +0000 (09:14 +0200)]
gsk: Add GskTransform autocleanup definition
Alexander Mikhaylenko [Wed, 6 May 2020 13:38:59 +0000 (18:38 +0500)]
testsuite: Update bloomfilter test
Add the 2 new css nodes.
Alexander Mikhaylenko [Sat, 2 May 2020 15:37:51 +0000 (20:37 +0500)]
window: Stop handling dragging and titlebar actions
Since GtkWindowHandle and GtkHeaderBar do it now, it can be removed from
GtkWindow, along with GTK_WINDOW_REGION_TITLE which at this point doesn't
differ from GTK_WINDOW_REGION_CONTENT.
Closes https://gitlab.gnome.org/GNOME/gtk/-/issues/2689, since
GtkWindowHandle doesn't do that anymore.
Alexander Mikhaylenko [Sat, 2 May 2020 15:37:41 +0000 (20:37 +0500)]
headerbar: Include GtkWindowHandle
This allows it to continue being draggable when placed inside a window, and
will allow to remove the corresponding gestures from GtkWindow.
Alexander Mikhaylenko [Fri, 1 May 2020 22:01:12 +0000 (03:01 +0500)]
headerbar: Use GtkCenterBox internally
This will allow to easily wrap it into another widget in the next commits.
Alexander Mikhaylenko [Sat, 2 May 2020 15:37:32 +0000 (20:37 +0500)]
Add GtkWindowHandle
This will allow to move the titlebar handling logic out from GtkWindow.
Carlos Garcia Campos [Thu, 7 May 2020 09:21:18 +0000 (11:21 +0200)]
clipboard: GdkContentProviderUnion should return after writing the first matched format
It continues trying with the other providers due to a missing early
return.
Alexander Mikhaylenko [Sat, 2 May 2020 15:34:15 +0000 (20:34 +0500)]
widget: Pass parent to gtk_widget_consumes_motion()
Right now it assumes that the parent is a GtkWindow. This will break when
window dragging is handled by another widget.
Matthias Clasen [Thu, 7 May 2020 02:56:04 +0000 (02:56 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Fix an inspector crash
See merge request GNOME/gtk!1855
Matthias Clasen [Thu, 7 May 2020 02:25:51 +0000 (22:25 -0400)]
Fix an inspector crash
Fix the listmodel semantics of the controller model,
by making get_item return a reference.
This was broken in
4b9e5304cc.
Matthias Clasen [Thu, 7 May 2020 01:40:39 +0000 (01:40 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
modelbutton: Unify activation code paths
See merge request GNOME/gtk!1854
Matthias Clasen [Thu, 7 May 2020 00:25:42 +0000 (20:25 -0400)]
modelbutton: Unify activation code paths
Opening submenus by Enter or Space wasn't working,
because we had different code paths for activation
via keynav and via click. Unify them.
Emmanuele Bassi [Wed, 6 May 2020 22:53:42 +0000 (22:53 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!1853
Emmanuele Bassi [Wed, 6 May 2020 18:31:07 +0000 (19:31 +0100)]
Annotate gtk_text_child_anchor_get_widgets() correctly
We switched from returning a list to returning a C array, which means we
need to update the introspection annotation and the documentation to
match the implementation.
Emmanuele Bassi [Wed, 6 May 2020 18:28:33 +0000 (19:28 +0100)]
Annotate gdk_motion_event_get_history() correctly
We moved from returning a list to returning a C array, and this requires
a change in the annotations.
Georges Basile Stavracas Neto [Wed, 6 May 2020 22:02:17 +0000 (22:02 +0000)]
Merge branch 'gbsneto/array-clear-func' into 'master'
icontheme: Don't free array element
Closes #2717
See merge request GNOME/gtk!1851
Matthias Clasen [Wed, 6 May 2020 21:47:47 +0000 (21:47 +0000)]
Merge branch 'wip/exalm/polish' into 'master'
Random polish
See merge request GNOME/gtk!1850
Matthias Clasen [Wed, 6 May 2020 21:35:08 +0000 (21:35 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
nodeeditor: Don't use container api on list box rows
See merge request GNOME/gtk!1852
Georges Basile Stavracas Neto [Wed, 6 May 2020 21:06:09 +0000 (18:06 -0300)]
icontheme: Don't free array element
When setting a clear function on a GArray, unlike
most other places, this free func is expected to
*not* free the array element itself -- only its
contents.
Don't free the array element.
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/2717
Matthias Clasen [Wed, 6 May 2020 21:03:12 +0000 (17:03 -0400)]
nodeeditor: Don't use container api on list box rows
GtkListBoxRow is not a container anymore.
Alexander Mikhaylenko [Wed, 6 May 2020 20:29:33 +0000 (01:29 +0500)]
widget-factory: Remove duplicate margin-start
Alexander Mikhaylenko [Wed, 6 May 2020 20:29:20 +0000 (01:29 +0500)]
widget-factory: Align spinbutton in the list on page 2
Alexander Mikhaylenko [Wed, 6 May 2020 20:21:26 +0000 (01:21 +0500)]
video: Use more appropriate revealer transition
Matthias Clasen [Wed, 6 May 2020 20:13:22 +0000 (20:13 +0000)]
Merge branch 'gbsneto/fix-text-child-header' into 'master'
textchild: Include <gtk/gtkwidget.h>
See merge request GNOME/gtk!1846
Matthias Clasen [Wed, 6 May 2020 20:02:27 +0000 (20:02 +0000)]
Merge branch 'master.struct.msvc' into 'master'
gtk/gtkaccelgroup.c: Fix build on Visual Studio
See merge request GNOME/gtk!1785
Matthias Clasen [Wed, 6 May 2020 20:01:45 +0000 (20:01 +0000)]
Merge branch 'wip/exalm/row' into 'master'
placesview: Stop using gtk_container_add() for GtkListBoxRow
See merge request GNOME/gtk!1849
Alexander Mikhaylenko [Wed, 6 May 2020 20:01:12 +0000 (01:01 +0500)]
adwaita: Remove a redundant -gtk-icon-shadow: none
Buttons have no icon shadows anymore anyway.
Alexander Mikhaylenko [Wed, 6 May 2020 19:59:44 +0000 (00:59 +0500)]
adwaita: Don't style window menu button anymore
Those were removed with the introduction of GtkWindowControls, no need to
exclude them from the round style anymore.
Alexander Mikhaylenko [Wed, 6 May 2020 19:37:55 +0000 (00:37 +0500)]
adwaita: Use tabular figures where appropriate
Port
82b9be3297db7baeb605c286b01978bab02b5373 from GTK3.
Matthias Clasen [Wed, 6 May 2020 19:25:32 +0000 (19:25 +0000)]
Merge branch 'drop-click-gesture-area' into 'master'
gestureclick: Drop the area
See merge request GNOME/gtk!1847
Matthias Clasen [Wed, 6 May 2020 19:24:58 +0000 (19:24 +0000)]
Merge branch 'master-disable-introspection' into 'master'
CI: disable introspection with mingw to avoid flaky builds
See merge request GNOME/gtk!1848
Christoph Reiter [Wed, 6 May 2020 19:19:52 +0000 (21:19 +0200)]
CI: use bash style variable expansion for the mingw cache key
It doesn't understand the powershell syntax which leads to the cache
key being empty which leads to cache restore being skipped
which leads to slow builds not using ccache.
See https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2747
Jakub Steiner [Wed, 6 May 2020 19:22:27 +0000 (19:22 +0000)]
Merge branch 'wip/jimmac/HC-focus' into 'master'
HC: more contrasty focus rings
See merge request GNOME/gtk!1845
Alexander Mikhaylenko [Wed, 6 May 2020 19:19:03 +0000 (00:19 +0500)]
adwaita: Make popover border transparent
Port
379669b153595fd1a33b200f6b08e7d5ba0407f4 from GTK3.
Matthias Clasen [Wed, 6 May 2020 19:15:31 +0000 (19:15 +0000)]
Merge branch 'abolish-size-allocate' into 'master'
Abolish size allocate
Closes #2705
See merge request GNOME/gtk!1833
Alexander Mikhaylenko [Wed, 6 May 2020 19:15:19 +0000 (00:15 +0500)]
adwaita: Update app icon shadow
Port
f95f3c707aa5a4b1c7b76b2bb43a43519eaf9433 from GTK3.
Alexander Mikhaylenko [Wed, 6 May 2020 17:10:16 +0000 (22:10 +0500)]
placesview: Stop using gtk_container_add() for GtkListBoxRow
Matthias Clasen [Wed, 6 May 2020 19:08:36 +0000 (15:08 -0400)]
Update CONTRIBUTING.md
Point to discourse, rather than mailing lists.
Based on a suggestion by sujiniku,
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1763
Matthias Clasen [Wed, 6 May 2020 19:01:25 +0000 (19:01 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
keymap: Remove leftover code
See merge request GNOME/gtk!1844
Christoph Reiter [Wed, 6 May 2020 18:33:46 +0000 (20:33 +0200)]
CI: disable introspection with mingw to avoid flaky builds
g-i has started to fail and it's not clear why, so disable it for
now to keep the build green.
See https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/340
Matthias Clasen [Wed, 6 May 2020 18:32:09 +0000 (18:32 +0000)]
Merge branch 'wip/jimmac/dark-seuggested' into 'master'
Adwaita: tone down suggested focus ring for dark
See merge request GNOME/gtk!1843
Matthias Clasen [Wed, 6 May 2020 03:12:20 +0000 (23:12 -0400)]
widget: Drop the ::size-allocate signal
This signal is mainly used for bad things, and we
don't want to emit signals during layout if we can
avoid it.
If you are subclassing, you should either use a
layout manager or override the size_allocate vfunc.
If you are using a GtkDrawingArea or GtkGLArea,
use their ::resize signals to learn about size
changes.
Fixes: #2705
Matthias Clasen [Wed, 6 May 2020 02:11:55 +0000 (22:11 -0400)]
tooltipwindow: Stop using the ::size-allocate signal
Instead of connecting to ::size-allocate, call
gtk_native_set_tooltip and rely on the native
to allocate the tooltip window.